Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redundant import #2019

Merged
merged 2 commits into from
May 10, 2022
Merged

Fix redundant import #2019

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e04c12f
Fixed merge error
tgaddair May 10, 2022
f1b6db4
Use original import path
tgaddair May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/integration_tests/test_custom_components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from torch import nn, Tensor

from ludwig.api import LudwigModel
from ludwig.combiners.combiners import BaseCombinerConfig, Combiner, register_combiner
from ludwig.combiners.combiners import Combiner, register_combiner
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete line 18 instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is the correct change - BaseCombinerConfig is not exposed by ludwig.combiners.combiners

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked line 18 more because it's the true location of that class, as opposed to an indirect import.

from ludwig.constants import NUMBER, TRAINER
from ludwig.decoders.base import Decoder
from ludwig.decoders.registry import register_decoder
Expand Down