Adds rule of thumb for determining embeddings size #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w4nderlust
requested review from
justinxzhao,
ShreyaR and
dantreiman
and removed request for
justinxzhao
jppgks
approved these changes
May 23, 2022
Just some empirical use: https://forums.fast.ai/t/size-of-embedding-for-categorical-variables/42608/2?u=knesgood |
justinxzhao
approved these changes
May 23, 2022
justinxzhao
added a commit
that referenced
this pull request
May 27, 2022
This reverts commit 37db773.
tgaddair
pushed a commit
that referenced
this pull request
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes the default behavior for dense category embed encoder. This has repercussions on documentation, where we should document the rule of thumb for determining size if unspecified: min(512, round(1.6 * x**0.56))