Comprehensive configs for trainer and combiner. #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksbrar
reviewed
Jun 9, 2022
connor-mccorm
approved these changes
Jun 10, 2022
ksbrar
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
defaults.pyto source defaults directly from theTrainerConfig,OptimizerConfig, andBaseCombinerConfigmarshmallow schemas.Going forward, we'll have a single source of defaults (the schemas). Merging with the full schema also enables Ludwig to print and save comprehensive configs, which contain an exhaustive list of parameters, for Trainer and Combiner, insulating older models from subsequent changes to module constructor values, like #2050, which we reverted in #2069.
Config diff. You'll notice that there are many more parameters in the config from trainer and combiner.