Make text encoder trainable property default to False for pre-trained HF encoders #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinxzhao
added a commit
that referenced
this pull request
Jun 30, 2022
This reverts commit e0a786d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our documentation says that the default value of
trainableis False. Updating code to match that:https://ludwig-ai.github.io/ludwig-docs/0.5/configuration/features/text_features/#huggingface-models
This also matches expectations learned from user feedback: if using a pretrained model, default behavior should be to freeze the pretrained model and train the prediction layers using the pretrained model's embeddings.
\