Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make text encoder trainable property default to False for pre-trained HF encoders" #2220

Closed
wants to merge 1 commit into from
Closed

Revert "Make text encoder trainable property default to False for pre-trained HF encoders" #2220

wants to merge 1 commit into from

Conversation

justinxzhao
Copy link
Contributor

Reverts #2060

@github-actions
Copy link

github-actions bot commented Jun 30, 2022 •
edited
Loading

Unit Test Results

       5 files   -     1         5 suites   - 1   2h 6m 51s ⏱️ - 18m 26s
2 908 tests ±    0  2 862 ✔️ ±    0    46 💤 ±  0  0 ❌ ±0 
8 556 runs   - 168  8 437 ✔️  - 145  119 💤  - 23  0 ❌ ±0 

Results for commit 457a7c1. ± Comparison against base commit 5df979f.

♻️ This comment has been updated with latest results.

@justinxzhao
Copy link
Contributor Author

FYI @abidwael @dantreiman, closing this PR to keep pre-trained encoders not trainable by default.

In benchmarks, we can add trainable: true to all text input features until we find a configuration that suitably matches the performance of models without trainable: true.

@justinxzhao justinxzhao closed this Jul 6, 2022
@justinxzhao justinxzhao deleted the revert-2060-daniel/trainable_default_false branch July 12, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@justinxzhao