Deflakes and refactors torchscript tests #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinxzhao
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the torchscript tests in a manner similar to
test_ray.py::test_ray_{tabular|text|sequence|audio|image|timeseries}in order to surface output parity issues in a faster and more isolated manner. This should also reduce the time taken by each individual test.This PR deflakes the torchscript tests by increasing the tolerance when comparing ludwig models and torchscript models trained on audio features. Audio features introduce some numerical mismatch (#2110), likely due to the complex preprocessing. Next steps include investigating this issue further.