HYPEROPT: Migrate Sampler functionality to Executor #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrating sampler functionality to Executor
for more information, see https://pre-commit.ci
…o refactor-hyperopt-sampler
for more information, see https://pre-commit.ci
…o refactor-hyperopt-sampler
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…o refactor-hyperopt-sampler
w4nderlust
approved these changes
Jun 19, 2022
justinxzhao
approved these changes
Jun 21, 2022
ShreyaR
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Looks great @jimthompson5802! Added a small comment, feel free to merge whenever you get a chance to address it.
consolidated code to simplify setup of search algorithm in executor
Remove redundant code and add typing
…-sampler # Conflicts: # ludwig/hyperopt/execution.py
for more information, see https://pre-commit.ci
…o refactor-hyperopt-sampler
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Pull Requests
Code refactoring to simplify internal code structure.
High-level changes:
samplying.pytoexecution.pyRayExecutorinitializer to reflect refactored code