Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ray.state.nodes() with ray.nodes(). #2183

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Conversation

justinxzhao
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 22, 2022

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 28m 34s ⏱️ + 10m 31s
2 832 tests +1  2 798 ✔️ +2    34 💤 ±0  0  - 1 
8 496 runs  +3  8 390 ✔️ +4  106 💤 ±0  0  - 1 

Results for commit e087af3. ± Comparison against base commit 18f2c2f.

♻️ This comment has been updated with latest results.

@tgaddair
Copy link
Collaborator

https://github.com/ludwig-ai/ludwig/runs/6998208225?check_suite_focus=true#step:10:2220

ValueError: Metadata mismatch found in `from_delayed`.

Maybe @clarkzinzow knows why this is suddenly popping up?

@justinxzhao
Copy link
Collaborator Author

@tgaddair @clarkzinzow There's some flakiness with the hyperopt integration tests.

After re-running the CI, the test with the Metadata mismatch error went away.

However, we're still running into an error with tests/integration_tests/test_hyperopt_ray.py::test_hyperopt_ray_mlflow

Here's the error

>   from ray.util.ml_utils.mlflow import MLflowLoggerUtil as _MLflowLoggerUtil
E   ImportError: cannot import name 'MLflowLoggerUtil' from 'ray.util.ml_utils.mlflow' (/opt/hostedtoolcache/Python/3.9.13/x64/lib/python3.9/site-packages/ray/util/ml_utils/mlflow.py)

@justinxzhao justinxzhao marked this pull request as ready for review June 22, 2022 21:52
@justinxzhao
Copy link
Collaborator Author

The MLflowLoggerUtil issue was due to a temporary workaround that was implemented in Ludwig that is no longer needed with newer versions of Ray.

@justinxzhao justinxzhao merged commit 8c6e189 into master Jun 22, 2022
@justinxzhao justinxzhao deleted the ray_nightly_fix branch June 22, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants