Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick fixes to 0.5 #2257

Merged
merged 6 commits into from
Jul 12, 2022
Merged

Cherrypick fixes to 0.5 #2257

merged 6 commits into from
Jul 12, 2022

Conversation

justinxzhao
Copy link
Contributor

@justinxzhao justinxzhao commented Jul 11, 2022 •
edited
Loading

justinxzhao and others added 3 commits July 11, 2022 18:43
@justinxzhao
Add an explicit call to merge_wtih_defaults() when loading a config f…
dc1a1d8 
…rom a model directory. (#2226)

* Add call to merge_wtih_defaults in api.py.

* Add a test that loads an old model (from S3) and uses it to run prediction.

* Use zipped file + wget to load old Ludwig model from a zipped file, hosted on S3.
@arnavgarg1 @justinxzhao
Hyperopt steps per epoch not being computed correctly (#2175)
f835751 
* getting count of dataset instead of window

* read length from dataset instead of pipeline

* Removing older commented code

* Refactor

* Removing dead code

* Modify RayDatasetShard length to factor in windowing and dataset partitions

* Moving to iter_epochs()

* Working fix
@geoffreyangus @justinxzhao
Adds ability to read images from numpy files and numpy arrays (#2212)
fc06782
@justinxzhao justinxzhao marked this pull request as ready for review July 11, 2022 22:50
@github-actions
Copy link

github-actions bot commented Jul 12, 2022 •
edited
Loading

Unit Test Results

       6 files         6 suites   2h 27m 36s ⏱️
2 860 tests 2 826 ✔️   34 💤 0 ❌
8 580 runs  8 474 ✔️ 106 💤 0 ❌

Results for commit 6634fba.

♻️ This comment has been updated with latest results.

@tgaddair
Copy link
Collaborator

@justinxzhao, #2248 shouldn't be included. We do need to incorporate the jsonschema pin, however.

@justinxzhao
Copy link
Contributor Author

@justinxzhao, #2248 shouldn't be included. We do need to incorporate the jsonschema pin, however.

Good catch -- I was wondering why more tests were starting to fail. Removed #2248, and incorporated the jsonschema pin.

@tgaddair
Copy link
Collaborator

Looks like we may need a few more fixed:

@justinxzhao
Copy link
Contributor Author

Looks like #2128 and #2183 were already in 0.5.3. Cherry-picked #2196 -- and it looks like the tests are all passing now.

@tgaddair tgaddair merged commit dab4c24 into 0.5-stable Jul 12, 2022
@tgaddair tgaddair deleted the 0.5-cp branch July 12, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair tgaddair approved these changes

@dantreiman dantreiman Awaiting requested review from dantreiman

@w4nderlust w4nderlust Awaiting requested review from w4nderlust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justinxzhao @tgaddair @arnavgarg1 @geoffreyangus @jppgks