Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an explicit call to merge_wtih_defaults() when loading a config from a model directory. #2226

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Add an explicit call to merge_wtih_defaults() when loading a config from a model directory. #2226

merged 3 commits into from
Jul 6, 2022

Conversation

justinxzhao
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 30, 2022 •
edited
Loading

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 32m 36s ⏱️ - 4m 34s
2 910 tests +2  2 864 ✔️ +2    46 💤 ±0  0 ❌ ±0 
8 730 runs  +6  8 588 ✔️ +6  142 💤 ±0  0 ❌ ±0 

Results for commit 2d08502. ± Comparison against base commit 9d7da5f.

♻️ This comment has been updated with latest results.

tgaddair
tgaddair requested changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that loads an old Ludwig model and runs predict(). This can be stored in s3 at a public URL.

@justinxzhao justinxzhao requested a review from tgaddair July 5, 2022 21:34
@justinxzhao justinxzhao marked this pull request as ready for review July 6, 2022 00:22
@justinxzhao justinxzhao merged commit 5d6a970 into master Jul 6, 2022
@justinxzhao justinxzhao deleted the merge_with_defaults branch July 6, 2022 00:22
justinxzhao added a commit that referenced this pull request Jul 11, 2022
@justinxzhao
Add an explicit call to merge_wtih_defaults() when loading a config f…
dc1a1d8 
…rom a model directory. (#2226)

* Add call to merge_wtih_defaults in api.py.

* Add a test that loads an old model (from S3) and uses it to run prediction.

* Use zipped file + wget to load old Ludwig model from a zipped file, hosted on S3.
@justinxzhao justinxzhao mentioned this pull request Jul 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair tgaddair approved these changes

@jppgks jppgks jppgks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinxzhao @tgaddair @jppgks