Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-memory dataset size calculation to dataset statistics and hyperopt (#2509) #2518

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

arnavgarg1
Copy link
Contributor

Resolves merge conflicts from failed cherry-pick

* add in-memory dataset size calculation

* reduce constraints on test

* Fix failing tests by adding conditional checks before function call

* merge into single tab, use memory formatter, fix conditional

* clean up

* make benchmarking a module
* surfacing dataset statistics in hyperopt

* make datasets loaders a module
@arnavgarg1 arnavgarg1 changed the title Add in-memory dataset size calculation to dataset statistics (#2509) Add in-memory dataset size calculation to dataset statistics and hyperopt (#2509) Sep 16, 2022
@arnavgarg1 arnavgarg1 marked this pull request as ready for review September 16, 2022 22:23
@github-actions
Copy link

Unit Test Results

         6 files  ±0         6 suites  ±0   2h 41m 16s ⏱️ +47s
  3 391 tests +2  3 313 ✔️ +3    78 💤 ±0  0  - 1 
10 173 runs  +6  9 916 ✔️ +7  257 💤 ±0  0  - 1 

Results for commit 75ddbc5. ± Comparison against base commit 4156ca6.

@arnavgarg1 arnavgarg1 merged commit 94af081 into release-0.6 Sep 16, 2022
@arnavgarg1 arnavgarg1 deleted the arnav_cherry_pick branch September 16, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants