Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker image upgrades to Python 3.9, Ray 2.3.1, Torch 2.0.0, CUDA 11.8. Deprecating Horovod #3320

Merged
merged 24 commits into from
Apr 5, 2023
Merged

Docker image upgrades to Python 3.9, Ray 2.3.1, Torch 2.0.0, CUDA 11.8. Deprecating Horovod #3320

merged 24 commits into from
Apr 5, 2023

Conversation

abidwael
Copy link
Contributor

@abidwael abidwael commented Apr 4, 2023 •
edited

This PR upgrades the Docker images to use

  • Python 3.9
  • Ray 2.3.1
  • Torch 2.0.0
  • CUDA 11.8.

This also deprecates Horovod in the Docker images and moves it to requirements_extra.txt

@github-actions
Copy link

github-actions bot commented Apr 4, 2023 •
edited

Unit Test Results

    4 files   -     2      4 suites   - 2   1h 56m 30s ⏱️ + 1h 35m 54s
171 tests +159  154 ✔️ +144  17 💤 +15  0 ❌ ±0 
183 runs  +123  164 ✔️ +116  19 💤 +  7  0 ❌ ±0 

Results for commit b1974c0. ± Comparison against base commit 3246acd.

♻️ This comment has been updated with latest results.

@abidwael abidwael mentioned this pull request Apr 4, 2023
Closed
@abidwael abidwael changed the title Make Horovod optional Docker image upgrades to Python 3.9, Ray 2.3.1, Torch 2.0.0, CUDA 11.8. Deprecating Horovod Apr 4, 2023
arnavgarg1
arnavgarg1 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@arnavgarg1 arnavgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT, but tests seeem to be failing

@abidwael abidwael merged commit cf5c604 into master Apr 5, 2023
7 of 8 checks passed
@abidwael abidwael deleted the deprecate-horovod branch April 5, 2023 19:11
@abidwael abidwael mentioned this pull request Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair tgaddair approved these changes

@justinxzhao justinxzhao justinxzhao approved these changes

@arnavgarg1 arnavgarg1 arnavgarg1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abidwael @tgaddair @justinxzhao @arnavgarg1