Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade docker images to use Python 3.8 #3325

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

abidwael
Copy link
Contributor

@abidwael abidwael commented Apr 6, 2023

In #3320, we update the docker images to use Python 3.9.

In #3324, we update the type hinting to match what's accepted in Python 3.9, we see the following failure in the CI (failures for torchscript tests). By following the torchscript typing guide, it looks like only python 3.8-style type hints are accepted.

In this PR, we use Python 3.8 in the docker images.

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Unit Test Results

  4 files  ±0    4 suites  ±0   27m 24s ⏱️ - 1m 19s
33 tests ±0  30 ✔️ ±0  3 💤 ±0  0 ±0 
53 runs  ±0  46 ✔️ ±0  7 💤 ±0  0 ±0 

Results for commit 774e7ce. ± Comparison against base commit e49eae9.

@abidwael abidwael merged commit d68d96e into master Apr 6, 2023
7 of 8 checks passed
@abidwael abidwael deleted the docker-images-py38 branch April 6, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants