Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass #1

Merged
merged 3 commits into from
Jan 2, 2017
Merged

First pass #1

merged 3 commits into from
Jan 2, 2017

Conversation

luetkemj
Copy link
Owner

@luetkemj luetkemj commented Jan 2, 2017 •
edited
Loading

A functional first pass at a name generator. While this 'works' it provides sub optimal results. An example results set might be: ['ffoar', 'squid', 'ridsq', 'squsq', 'jenid', 'grids', 'squsq', 'manif', 'fonid']

@luetkemj
partly functional first pass
b7ef296 
works sometimes… there is a bug somewhere at the moment. But even when
it does work the results are super meh. Should try splitting names into
syllables or at least letter pairs. Currently this is a typical result
set:
'ffoar',
  'squid',
  'ridsq',
  'squsq',
  'jenid',
  'jenid',
  'grids',
  'squsq',
  'manif',
  'fonid'
@luetkemj
Bug fix
30ed86b 
Some tokens always occur at the end of a string and therefore do not
have their own row. We now just return what we have if we end up in
that situation rather than blow up.
@luetkemj
Fix build
2f71fcf 
had a listing error I missed. Always ‘npm run test’ before PR! ‘npm run
test:watch’ only runs tests - not the linter as well :P
@luetkemj luetkemj merged commit 3899d38 into master Jan 2, 2017
@luetkemj luetkemj deleted the first_pass branch January 2, 2017 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@luetkemj