Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genericize monster-details component into multiple reusable stat components #15

Closed
luetkemj opened this issue Jul 23, 2016 · 0 comments
Closed

Genericize monster-details component into multiple reusable stat components #15

luetkemj opened this issue Jul 23, 2016 · 0 comments
Assignees
@luetkemj

Comments

@luetkemj
Copy link
Owner

luetkemj commented Jul 23, 2016 •
edited

Many part of the monster details component could be reused for items, npcs, etc. Break it down into reusable pieces that can be combine to satisfy the many stat blocks we will need.
luetkemj added a commit that referenced this issue Jul 31, 2016
@luetkemj
[#15] Genericize Components
8b06453 
Goal was to refactor the monster container into generic pieces that
could be reused. This was accomplished by creating a definitionList
component for semantic markup of stats, abilities, and actions as well
as a component for ability scores that will be used heavily.
- create ability score component
- create definition list component
- add fragments utils to build semantic dl markup
- add create fragment addon to dependencies and update requirements
- refactor monster-details to use new components
- update list component to be more generic and not depend on _id for
keys
- component tests
- typography function for reuse and to bypass compose limitations
- add ability score abrv to monsterUI model
luetkemj added a commit that referenced this issue Jul 31, 2016
@luetkemj
Merge pull request #25 from luetkemj/genericize_components
0046448 
[#15] Genericize Components
@luetkemj luetkemj closed this as completed Aug 2, 2016
@luetkemj luetkemj removed the 4 - Done label Aug 2, 2016
@luetkemj luetkemj self-assigned this Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luetkemj luetkemj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luetkemj