Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#15] Genericize Components #25

Merged
merged 1 commit into from Jul 31, 2016
Merged

[#15] Genericize Components #25

merged 1 commit into from Jul 31, 2016

Conversation

luetkemj
Copy link
Owner

@luetkemj luetkemj commented Jul 31, 2016

Goal was to refactor the monster container into generic pieces that
could be reused. This was accomplished by creating a definitionList
component for semantic markup of stats, abilities, and actions as well
as a component for ability scores that will be used heavily.

  • create ability score component
  • create definition list component
  • add fragments utils to build semantic dl markup
  • add create fragment addon to dependencies and update requirements
  • refactor monster-details to use new components
  • update list component to be more generic and not depend on _id for
    keys
  • component tests
  • typography function for reuse and to bypass compose limitations
  • add ability score abrv to monsterUI model

Goal was to refactor the monster container into generic pieces that
could be reused. This was accomplished by creating a definitionList
component for semantic markup of stats, abilities, and actions as well
as a component for ability scores that will be used heavily.
- create ability score component
- create definition list component
- add fragments utils to build semantic dl markup
- add create fragment addon to dependencies and update requirements
- refactor monster-details to use new components
- update list component to be more generic and not depend on _id for
keys
- component tests
- typography function for reuse and to bypass compose limitations
- add ability score abrv to monsterUI model
@luetkemj luetkemj merged commit 0046448 into master Jul 31, 2016
@luetkemj luetkemj deleted the genericize_components branch July 31, 2016 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant