Implement grpc env-set and env-unset #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aguerra
force-pushed
the
ag-grpc-app-setenv
branch
from
76b2862
to
4757dd2
Compare
pkg/server/app/app.go
Outdated
| @@ -218,6 +225,103 @@ func (ops *AppOperations) Get(appName string) (*App, error) { | |||
| return a, nil | |||
| } | |||
|
|
|||
| func (ops *AppOperations) appInstance(user *storage.User, appName string) (*App, error) { | |||
| team, err := ops.kops.NamespaceLabel(appName, TeresaTeamLabel) | |||
There was a problem hiding this comment.
AppOperations has method ops.TeamName
pkg/server/app/app.go
Outdated
| return nil, auth.ErrPermissionDenied | ||
| } | ||
|
|
||
| an, err := ops.kops.NamespaceAnnotation(appName, TeresaAnnotation) |
There was a problem hiding this comment.
for this line until 247, you should change to app, err := ops.Get(appName).
added 4 commits
July 17, 2017 16:01
For now it has just the name of the protected env vars.
aguerra
force-pushed
the
ag-grpc-app-setenv
branch
from
4757dd2
to
c6e8d36
Compare
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper logging (possibly using middleware) and adding context to errors will be done in the next PR's.
This change is