Run release command from Procfile in Deploy flow
#226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
aguerra
approved these changes
Jul 31, 2017
pkg/server/deploy/errors.go
Outdated
| @@ -7,5 +7,6 @@ import ( | |||
|
|
|||
| var ( | |||
| ErrBuildFail = status.Errorf(codes.Unknown, "Build return a non zero value") | |||
| ErrReleaseFail = status.Errorf(codes.Unknown, "Release command return a non zero value") | |||
| ErrInvalidTeresaYamlFile = status.Errorf(codes.InvalidArgument, "Invalid Teresa Yaml file") | |||
pkg/server/deploy/deploy.go
Outdated
| @@ -68,7 +68,7 @@ func (ops *DeployOperations) Deploy(user *storage.User, appName string, tarBall | |||
| slugURL := fmt.Sprintf("%s/slug.tgz", buildDest) | |||
| releaseCmd := confFiles.Procfile[ProcfileReleaseCmd] | |||
| if confFiles.Procfile != nil && releaseCmd != "" { | |||
| if err := ops.runReleaseCmd(a, slugURL, w); err != nil { | |||
| if err := ops.runReleaseCmd(a, deployId, slugURL, w); err != nil { | |||
| log.WithError(err).Errorf("Running release command %s in app %s", releaseCmd, appName) | |||
There was a problem hiding this comment.
Maybe log deployId on errors, don't know if it's useful for debugging.
There was a problem hiding this comment.
Why not? I'll add
|
@aguerra updated |
i.e. `teresa.yaml` and `Procfile`
drgarcia1986
force-pushed
the
dg-release_command
branch
from
2742ede
to
226aeba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the most wanted feature according to our users!
This feature enables devs to run tasks (e.g. migrations, APM deploy notify, etc) before update the current deploy.
The release command will be run between build phase and deploy update phase. If some error comes across in release phase the deployed content won't be updated.
This change is