Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: clean up feature usage #68

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

luizirber
Copy link
Owner

Fix #56

This will likely need a major release and docs showing how to use the replaced features

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.57%. Comparing base (6db5584) to head (b86af89).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files          12       12           
  Lines         266      266           
=======================================
  Hits          217      217           
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@natir
Copy link
Collaborator

natir commented Jun 10, 2024

I see remove feature create a major change so I stop my work on it. Add this sub-feature is definitively a bad idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After bump to 1.60 at MSRV clean features
2 participants