Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with assert-j to 3.20 #379

Closed
carlmolemans opened this issue Jun 16, 2021 · 3 comments
Closed

Incompatibility with assert-j to 3.20 #379

carlmolemans opened this issue Jun 16, 2021 · 3 comments

Comments

@carlmolemans
Copy link

Some methods were made final which are overwritten in json-unit-assertj.
Eg. AbstractMapAssert.contains(Entry) is now final in assertj.

Example stack:
ava.lang.VerifyError: class net.javacrumbs.jsonunit.assertj.JsonMapAssert overrides final method contains.([Ljava/util/Map$Entry;)Lorg/assertj/core/api/AbstractMapAssert;

at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at net.javacrumbs.jsonunit.assertj.JsonAssert.isObject(JsonAssert.java:131)
@lukas-krecan
Copy link
Owner

Thank you for reporting will fix it one way or the other.

@lukas-krecan
Copy link
Owner

lukas-krecan added a commit that referenced this issue Jun 18, 2021
#379 AssertJ 3.20.0 compatibility
lukas-krecan added a commit that referenced this issue Jun 18, 2021
Revert "#379 AssertJ 3.20.0 compatibility"
lukas-krecan added a commit that referenced this issue Jun 18, 2021
#379 Make compatible with AssertJ 3.20.x
@lukas-krecan
Copy link
Owner

Released as 2.27.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants