-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow non-user dependent requests #26
Comments
When would you not pass userId? |
What about, instead of requiring userId as false, or setting it as default, just check if it's falsy and do:
|
@jmdiego That would be a breaking change, current implementation automatically inserts |
@thisdotvoid you are right, what about:
Your initial proposal also removed the empty user possibility, so, I guess this would be the most comprehensive solution to handle all three use cases. |
@jmdiego hmm you are right 🤔 made a pr |
What do you think about this change?
https://github.com/sarkestudio/fitbit-node/blob/master/fitbit-api-client.js#L26-L31
I can make a PR if it makes sense.
The text was updated successfully, but these errors were encountered: