Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues: #156
Requested Reviewers: @lukasturcani
Note for Reviewers: If you accept the review request add a 👍 to this post
Using a set for placer ids, required to solve #156, lead to badly formed structures for M3L3Triangle and M4L4Square. I determined this to be because the LinearVertex was on an "orthogonal" position, so a new Vertex is required.
Most source changes in:
src/stk/molecular/topology_graphs/cage/vertices.py
: New vertex implemented.Added new vertex test and new structure tests for the M3L3 Triangle - new position matrices needed.