Add type hints #458
Merged
Add type hints #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the key makers to explicitly provide type hints rather than rely on the default implementation. It is sometimes useful to be able to rely on the more specific type of the key.
|
This pull request introduces 3 alerts when merging f85223c into 34a2d14 - view on LGTM.com new alerts:
|
andrewtarzia
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
Makes sense to me after discussion with @lukasturcani in Discord.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested Reviewers: @andrewtarzia
Note for Reviewers: If you accept the review request add a 👍 to this post
Refactored the key makers to explicitly provide type hints rather
than rely on the default implementation. It is sometimes useful to
be able to rely on the more specific type of the key.