Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need an option which enable the clicking sound, it clicks during the working time #30

Closed
xiaochun-z opened this issue Aug 15, 2016 · 8 comments

Comments

@xiaochun-z
Copy link

xiaochun-z commented Aug 15, 2016

sometimes we need to hear something to notify us the time is flying, keep hard working on your job, don't waste your time, cannot give up, cannot die, not today, come on... hearing the click sound would remind me of "go, go, go".

even we can add more options for the sound, like white noise, the sound in coffee shop, street noise or what ever you can find.

it clicks all the time when working, currently we can hear the clicking when starting a task, and it disappears quickly.

And one last thing not related with the above: I don't know how to measure the time during 5 minutes reset.

@floatas
Copy link
Collaborator

floatas commented Aug 16, 2016

Well there are two options:

  1. We can add these sounds in dropdown and let user select what to play (different sounds for work\break). In this case we need to find sound files that could be used, without any licensing issues.
  2. Add audio file selector one for work and one for break.

Well we can start from 2 and if later someone find any good sound that could be used we can embed them.

Can you expand a bit more on 5 min reset ?

floatas added a commit that referenced this issue Sep 8, 2016
@floatas
Copy link
Collaborator

floatas commented Sep 8, 2016

Feel free to grab latest ClickOnce installer ant test it ;)

@xiaochun-z
Copy link
Author

that's awesome! great , thanks for these updates.

however, I don't find the clickonce installer, so I downloaded visual studio 2015 and re-build it myself, works great.

@floatas
Copy link
Collaborator

floatas commented Sep 19, 2016

Link to installer is in #32 issue

@xiaochun-z
Copy link
Author

Hi man, consider to make this change in MainWindow.xaml.cs, sometimes if the working directory is not correct, the application startup will fail.

  •        sysTrayIcon.Icon = new System.Drawing.Icon(@"Resources\pomoTray.ico", 40, 40);
    
  •        sysTrayIcon.Icon = new System.Drawing.Icon(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, @"Resources\pomoTray.ico"), 40, 40);
    

another thing is I found in this setup project, some output files are using absolute path, so it does not compile on my machine, maybe we can use this way:
http://stackoverflow.com/questions/15390098/installshield-le-relative-paths-to-file

@floatas
Copy link
Collaborator

floatas commented Sep 20, 2016

Fixed path for sysTrayIcon.Icon and created separate issue #35 for setup project

@xiaochun-z
Copy link
Author

xiaochun-z commented Sep 20, 2016

hello sir, I found some other issues such as when press stop button, it still plays work music, or when drag the main window, sometimes it crashes, or the resource path does not set correctly.

I created a git patch file and uploaded to one drive, if you're interested in, you can have a look(ignore all the audio resources change, the audio resource also makes the patch file big)
onedrive link to this patch file:
https://1drv.ms/u/s!AmwV7I2IHKTPnm6kx9o61UA2FiQa

main changes I did:
http://pastebin.com/iYcaruMu

@floatas
Copy link
Collaborator

floatas commented Sep 20, 2016

Maybe you can make pull request with all changes ?
Pull request would allow to discuss and review changes much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants