Add support for OrientDB 2.2. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.2 appears to make a few changes that affect error handling, namely: * 400 HTTP codes are returned for malformed/invalid queries and commands * for these requests, a java-style error class is no longer returned in the response In order to support this while not breaking backwards compatibility, we can introduce a new error class, `ParsingError` that inherits from `ClientError`. Older clients will continue to work, and anyone conditionally handling `ClientError`s by examining the error message and looking for a string like "OCommandSQLParsingException" can continue to do so, or alternatively rescue `ParsingError`. People using OrientDB >= 2.2 should not expect that these requests will have "OCommandSQLParsingException" in the error message/response body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.2 appears to make a few changes that affect error handling, namely:
In order to support this while not breaking backwards compatibility, we can introduce a new error class,
ParsingErrorthat inherits fromClientError. Older clients will continue to work, and anyone conditionally handlingClientErrors by examining the error message and looking for a string like "OCommandSQLParsingException" can continue to do so, or alternatively rescueParsingError.People using OrientDB >= 2.2 should not expect that these requests will have "OCommandSQLParsingException" in the error message/response body.