fix: missing optional file case in upload validate

lukeautry · Mar 13, 2024 · 41b1e48 · 41b1e48
1 parent de6b74d
commit 41b1e48
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/runtime/src/routeGeneration/templates/express/expressTemplateService.ts b/packages/runtime/src/routeGeneration/templates/express/expressTemplateService.ts
@@ -85,6 +85,10 @@ export class ExpressTemplateService extends TemplateService<ExpressApiHandlerPar
           const files = Object.values(args).filter(param => param.dataType === 'file');
           if (param.dataType === 'file' && files.length > 0) {
             const requestFiles = request.files as { [fileName: string]: Express.Multer.File[] };
+            if (requestFiles[name] === undefined) {
+              return undefined;
+            }
+
             const fileArgs = this.validationService.ValidateParam(param, requestFiles[name], name, fieldErrors, undefined, this.minimalSwaggerConfig);
             return fileArgs.length === 1 ? fileArgs[0] : fileArgs;
           } else if (param.dataType === 'array' && param.array && param.array.dataType === 'file') {

diff --git a/packages/runtime/src/routeGeneration/templates/koa/koaTemplateService.ts b/packages/runtime/src/routeGeneration/templates/koa/koaTemplateService.ts
@@ -94,6 +94,10 @@ export class KoaTemplateService extends TemplateService<KoaApiHandlerParameters,
           const files = Object.values(args).filter(param => param.dataType === 'file');
           const contextRequest = context.request as any;
           if (param.dataType === 'file' && files.length > 0) {
+            if (contextRequest.files[name] === undefined) {
+              return undefined;
+            }
+
             const fileArgs = this.validationService.ValidateParam(param, contextRequest.files[name], name, errorFields, undefined, this.minimalSwaggerConfig);
             return fileArgs.length === 1 ? fileArgs[0] : fileArgs;
           } else if (param.dataType === 'array' && param.array && param.array.dataType === 'file') {