Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/RequestProp to access variables inside request parameter @ controller method #1540

Merged
merged 3 commits into from
Jan 28, 2024

Conversation

jackey8616
Copy link
Collaborator

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues
Closes #1495
Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

This decorator requires preprocess some data inject.
Otherwise the validation would not pass.

Test plan
Tested in express, koa and hapi using decorator to access body/payload variable.

@jackey8616 jackey8616 changed the title Feat: RequestProp to access variables inside request parameter @ controller method Feat/RequestProp to access variables inside request parameter @ controller method Jan 16, 2024
Copy link
Collaborator

@WoH WoH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackey8616 jackey8616 mentioned this pull request Jan 23, 2024
5 tasks
@jackey8616
Copy link
Collaborator Author

@WoH This PR is good to go. thx.

@WoH WoH merged commit eeb3a91 into lukeautry:master Jan 28, 2024
18 checks passed
@jackey8616 jackey8616 deleted the feat/1495 branch January 28, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add posibility to get a property from the Request - @Request("username") Decorator
2 participants