Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/codecov #1544

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Feat/codecov #1544

merged 3 commits into from
Jan 23, 2024

Conversation

jackey8616
Copy link
Collaborator

@jackey8616 jackey8616 commented Jan 18, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues
Closes #836, #840

Details code coverage report can check my forked repo's actions output.

@jackey8616
Copy link
Collaborator Author

@WoH Can you re-run the failed job? Thx.
Actions in my repo is all passed.

@jackey8616 jackey8616 marked this pull request as ready for review January 18, 2024 08:38
@jackey8616
Copy link
Collaborator Author

@WoH I'm still trying to work on middleware & file decorator.
But currently I think everything is all set for code coverage.

@WoH WoH merged commit 4ebc2ad into lukeautry:master Jan 23, 2024
18 checks passed
@WoH
Copy link
Collaborator

WoH commented Jan 23, 2024

I hope that this does not mess around too much with lerna and ts, but only one way to know for sure :D

@jackey8616
Copy link
Collaborator Author

@WoH I've noticed that I missed esm tests cases while I was resolving conflicts in #1540 & #1541,
Could you revert this PR & re-open it?

After I resolve 1540 & 1541, and fix this pr, then I will ask for your review?

@WoH WoH mentioned this pull request Jan 23, 2024
@jackey8616 jackey8616 mentioned this pull request Feb 2, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DevSupport: Want a code coverage for complete test
2 participants