Add response object access to Express & Koa authentication middlewares #1557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Closing issues
Closes #1145
If this is a new feature submission:
See labels on issue.
Potential Problems With The Approach
I don't exactly like the fact that the response is added as the last argument to the middlewares, but this was done for the sake of backwards-compatibility.
Hapi was left out since I had a really difficult time understanding the inner workings of said library.
Test plan
Basic test cases added that confirm that when the response is modified in the authentication middleware, changes persist to the actual response.