Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.1.0 breaking change on Authentication middleware #1575

Closed
2 of 4 tasks
sl33kr opened this issue Mar 10, 2024 · 1 comment · Fixed by #1579
Closed
2 of 4 tasks

v6.1.0 breaking change on Authentication middleware #1575

sl33kr opened this issue Mar 10, 2024 · 1 comment · Fixed by #1579

Comments

@sl33kr
Copy link

sl33kr commented Mar 10, 2024

Upon upgrading from v6.0.1 to v6.1.0 our project started getting build errors on our generated routes.ts attempting to invoke our authentication middleware.

src/routes/routes.ts:1703:83 - error TS2554: Expected 2-3 arguments, but got 4.
expressAuthentication(request, name, secMethod[name], response)

Sorting

  • I'm submitting a ...

    • bug report
    • feature request
    • support request
  • I confirm that I

    • used the search to make sure that a similar issue hasn't already been submit

Expected Behavior

Build does not fail in minor version upgrade

Current Behavior

Build fails due to authentication method signature change.

Possible Solution

This possibly only affects projects with strict: true in the compiler options. It appears the breaking change occurred in #1557.

Context (Environment)

Version of the library: 6.1.0
Version of NodeJS: 18.19.1
Version of Typescript: 5.1.3

  • Confirm you were using yarn not npm: [ ]

Detailed Description

Breaking change?

Copy link

Hello there sl33kr 👋

Thank you for opening your very first issue in this project.

We will try to get back to you as soon as we can.👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant