Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/imports of TemplateService b/w cli & runtime #1574

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

jackey8616
Copy link
Collaborator

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

#1573

Only partially fix the incorrect import b/w @tsoa/cli & @tsoa/runtime.
Still finding a way to solve hapi & koa's dependency imports.

@ManfredLange
Copy link

If this helps to clearly separate between cli and runtime, and since this addresses the issue with the cli being imported in the tsoa-generated files, I'd love for this PR to be considered for merging as soon as possible. Thank you!

@WoH WoH merged commit 38d9bfc into lukeautry:master Mar 11, 2024
19 checks passed
@WoH WoH linked an issue Mar 11, 2024 that may be closed by this pull request
4 tasks
@jackey8616 jackey8616 deleted the fix/mix-import-of-cli-n-runtime branch March 13, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 6.1.0 leads to missing packages, breaks existing builds
3 participants