New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove panic calls from custom assertions #2

Closed

lukebayes opened this issue Mar 21, 2018 · 1 comment

Owner

lukebayes commented Mar 21, 2018

Update custom assertions so that they do not call panic directly.

These should return or trigger a test failure.

If it's what is required, we can pass the testing.T reference into these assertions and simply call t.Error or t.Errorf.

Owner Author

lukebayes commented Mar 21, 2018

Added this to the wrong project!

lukebayes closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment