Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex #19

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Fix regex #19

merged 2 commits into from
Apr 11, 2019

Conversation

nautilebleu
Copy link
Contributor

Allow to recognize URLs with an extension #18

@coveralls
Copy link

coveralls commented Apr 10, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 9b3bd44 on nautilebleu:master into 2cd1917 on lukechilds:master.

@lukechilds
Copy link
Owner

Brilliant, thanks!

Could you add a test for this functionality to prevent regressions too?

@nautilebleu
Copy link
Contributor Author

I added a test :)

@lukechilds lukechilds merged commit b215778 into lukechilds:master Apr 11, 2019
@lukechilds lukechilds mentioned this pull request Apr 11, 2019
Closed
@lukechilds
Copy link
Owner

Thanks!

Published as my-name-is-url@1.4.0 🎉

@nautilebleu
Copy link
Contributor Author

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nautilebleu @coveralls @lukechilds