Make properties enumerable + fix TS typings #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeed
reviewed
Dec 7, 2018
There was a problem hiding this comment.
Thanks Marvin, glad you like it! 🙌 Thanks for the PR, too 🙇
✅Not having enumerable was an oversight, oops.
🤔 I think the types are now wrong, differently. I don't use TS, so forgive me if this is incorrect, but it looks like there will be a new enabled property per-Color, even though enabled is only a top-level key. Is this right?
|
@lukeed Thanks for your review 👍 Good catch! You're right regarding the |
marvinhagemeister
force-pushed
the
typings
branch
from
727003e
to
a80c2a5
Compare
lukeed
reviewed
Dec 7, 2018
| * import kleur = require('kleur'); | ||
| */ | ||
| export let enabled: boolean; | ||
| declare let kleur: Kleur & { enabled: boolean }; |
There was a problem hiding this comment.
Hah, cheeky! Have never seen this before 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making another awesome library! Have used it in a few personal projects so far and love it 👍 While working with it I'm wondering if you're open to these two suggestions:
1) Make properties enumerable
A simple
console.log(kleur)would previously only showenabledproperty as available which might be confusing to newcomers. With this change it would list all available color properties.2) Fix TypeScript typings
TS typings for
commonjsmodules are not as straightforward as fores6based libraries. If the libraries code is exported viamodule.exports = myLibone cannot declare it asdefaultexports as this would create an ambiguity in regards to named exports.This PR changes that to the recommended way of changing the declaration to
export = myLib(verified locally).