Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional wildcards #25

Merged
merged 5 commits into from Dec 3, 2023
Merged

Optional wildcards #25

merged 5 commits into from Dec 3, 2023

Conversation

benmerckx
Copy link
Contributor

Closes #24

@molefrog
Copy link

molefrog commented Sep 8, 2023

Hi @lukeed, just wanted to ask if you could take a brief look at this.
This is the only thing that blocks us from switching to regexparam in https://github.com/molefrog/wouter.

src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fff88a1) 100.00% compared to head (d0e7521) 100.00%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           36        36           
=========================================
  Hits            36        36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this :) It's a breaking change due to how the "/books/*?" pattern will now match "/books" (shown in test), but I think it's a change worth having.

Cutting this as a 3.0 release

@lukeed lukeed merged commit 422f630 into lukeed:main Dec 3, 2023
7 checks passed
@molefrog
Copy link

molefrog commented Dec 9, 2023

@lukeed Thank you! We added it back as a dependency and it works well. molefrog/wouter#395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: optional wildcards
4 participants