This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Added unicode support and more commands #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support to callback option on send_wap_push command.
…f the generated Clickatell API message id
…hey come in as strings we can avoid typecasting by making the keys strings
…n using the CLI! Also converted a test case into a spec, not sure why it wasn't already a spec, doh.
…eds an explicit parameter for this
…s just one problem, give me the whole response back so I can parse it myself
Updated rspec to verison 2.+
|
Well, forget it I just find and fix a bug in the concatenation of unicode messages. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Luke, I added unicode flag support, send_mms_push, delete_message, and, off course, respective test cases for this.
Also update rspec to version 2+.