Updated solarized light and dark color schemes

[ntwb]

I have 'tweaked' the color assignments for both solarized light and dark themes.

• Primarily this brings the color assignments to match those of @neilpa's cmd-colors-solarized repo.
• Both dark & light schemes have identical color palettes with only a inverted ScreenColors and PopupColors
• Before and After pics attached below

[ntwb]

Before

After

Before

After

[lukesampson]

My colors are closer to the actual solarized values and have the benefit of black being darker than darkgrey. Do you want to send a pull request for solarized-reversed theme with these changes?

[ntwb]

My colors are closer to the actual solarized values

These are the exact same #hex colors, just the assignment of the #hex value to PowerShell color name has changed.I believe that this updated order/assignment of the color values better reflects the Solarized color palette naming standards

Solarized <> PowerShell (new)
yellow = yellow
red = red
magenta = magenta
cyan = cyan
green = green
blue = blue
orange = dark_red
violet = dark_magenta

... and have the benefit of black being darker than dark_gray.

My bad, I got these two backwards and have now switched them

The updated pull request only makes that black/dark_gray change.

I see where your coming from with solarized-reversed thinking though...

I don't really mind what we call them, your choice, from my viewpoint I see this pull request as solarized and the existing using the dark prefix for each color as solarized-reversed 😉

[lukesampson]

Ok. My rationale was that the Windows console color names use dark[color]/[color] whereas on Unix they're [color]/bright[color]. The lower indexed colors are the normal colors, whereas the higher indexed colours are brighter variations.

I did put some thought into this decision when I made it, but now you've convinced me that it wasn't very pragmatic. When people ask for green they expect green.

The problem with changing it now is that scoop and pshazz will show the wrong colors until people update concfg and re-import. Which isn't that big a deal, and it's easier to change it sooner rather than later, so I'm just going to merge this. Fingers crossed! 😬

[ntwb]

Yep, yeah, yes to all you wrote, couldn't agree more 👍

[ntwb]

I have soooooo many things with broken colors 😖

[lukesampson]

Oh no! Anything I need to fix?!

[ntwb]

My rationale was that the Windows console color names use dark[color]/[color] whereas on Unix they're [color]/bright[color]. The lower indexed colors are the normal colors, whereas the higher indexed colours are brighter variations.

That ^^^ has bitten my arse badly, all my PowerShell stuff looks oh so pretty, all my JavaScript & PHP repo's are not so pretty 😢 Specifically GruntJS and NodeJS are 50 shades of grey 😱

[lukesampson]

Oh ok—no worries. Shall we change it back?

[ntwb]

II think we should, I'll go and 'flip' the colors in all the themes and you can revert the other changes.

My bad, sorry, after a day and a half messing with colors it never dawned on me to test 'that stuff' 😠

[lukesampson]

No problem—at least we know how most programs work now ☺️