New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💬 Add missing i18n string #969
Conversation
@avm99963 is attempting to deploy a commit to the rallly Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe update to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- apps/web/public/locales/en/app.json
Files selected for processing (1)
- apps/web/src/components/time-zone-picker/time-zone-picker.tsx (3 hunks)
Additional comments: 3
apps/web/src/components/time-zone-picker/time-zone-picker.tsx (3)
11-11: The addition of the
useTranslation
hook from "next-i18next" is appropriate for enabling i18n capabilities within the component.152-154: The use of the
t
function with the key"timeZonePicker__ignore"
and a default value of"Ignore time zone"
is correct. This allows for the label to be internationalized. Ensure that the translation key is added to the respective i18n resource files.Verification successful
The shell script has successfully found the translation key
"timeZonePicker__ignore"
within a.json
file, which indicates that the key has been added to at least one i18n resource file. This aligns with the requirement for thet
function to work correctly, as it needs the translation keys to be present in the resource files to provide the necessary translations.* 159-159: The dependency array for `useMemo` has been correctly updated to include the `t` function, ensuring that `timeZoneOptions` is recalculated when the language changes.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that the translation key exists in all i18n resource files. fd '.*\.json$' --exec rg '"timeZonePicker__ignore":'Length of output: 102
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LGTM. Thanks! |
You're welcome :) Happy new year and sending the best wishes for you and Rallly! |
Description
Converts a hardcoded string of the time zone picker ("Ignore time zone") to a translatable string:
Checklist
Please check off all the following items with an "x" in the boxes before requesting a review.
Summary by CodeRabbit