Merge pull request #50 from fotonauts/better-fix

real way to solve the retain release problem
lukhnos · Sep 16, 2013 · c80643c · c80643c
2 parents 5fe98fb + 30012b7
commit c80643c
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/LFWebAPIKit/LFHTTPRequest.m b/LFWebAPIKit/LFHTTPRequest.m
@@ -211,9 +211,6 @@ - (void)readStreamHasBytesAvailable
     }
 
     if (!_receivedDataTracker) {
-        // self can be retained only by the timer (_requestMessageBodyTracker) so self can be deallocated while calling [_requestMessageBodyTracker invalidate]
-        // to avoid this problem:
-        [[self retain] autorelease];
 
         // update one last time the total sent bytes
         if ([_delegate respondsToSelector:@selector(httpRequest:sentBytes:total:)]) {
@@ -520,8 +517,8 @@ - (BOOL)_performMethod:(NSString *)methodName onURL:(NSURL *)url withData:(NSDat
     CFStreamClientContext streamContext;
     streamContext.version = 0;
     streamContext.info = self;
-    streamContext.retain = 0;
-    streamContext.release = 0;
+    streamContext.retain = (void *(*)(void *info))CFRetain;
+    streamContext.release = (void (*)(void *info))CFRelease;
     streamContext.copyDescription = 0;
 
     CFOptionFlags eventFlags = kCFStreamEventHasBytesAvailable | kCFStreamEventEndEncountered | kCFStreamEventErrorOccurred;
@@ -763,7 +760,7 @@ - (void)setShouldWaitUntilDone:(BOOL)waitUntilDone
 void LFHRReadStreamClientCallBack(CFReadStreamRef stream, CFStreamEventType eventType, void *clientCallBackInfo)
 {
     id pool = [NSAutoreleasePool new];
-
+    
     LFHTTPRequest *request = (LFHTTPRequest *)clientCallBackInfo;
     switch (eventType) {
         case kCFStreamEventHasBytesAvailable: