-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding passwordVisibility button #56
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
ready, can be merged <3 |
@lukin any updates? |
I'm planning to do some refactoring of this PR this week. Unfortunately, I can't devote much time to the project for now, so I'm prioritising trying to automate all the required and long-awaited processes. 🙂 |
@paulwer Please, if possible, check that everything works correctly on your side, and I'll merge it. |
I suspect it has to do with your custom styles. Please make sure you test the branch without modifications. 🙂 |
This comment was marked as outdated.
This comment was marked as outdated.
@lukin sometimes "sleeping" over it helped. The component works like a charm. It was a human error instead ❤️ sorry for that :) |
Hi, if i were to pick your commit for this, how do i find it? all of your pull requests show like 76 commits |
@lukin should I try to fix the optical issue or is this your task now? |
@lukin was the visual error fixed? |
@paulwer I have not been able to reproduce your error, and it is not reproducible in HTML templates. I suspect it has to do with cache or missing styles. |
Sorry for the confusion, for me it was indeed a caching issue. Cloudflare has cached the css and therefore it did not work. |
closes #13
this pr is related to the keycloak visibility behavior used in the base theme.