Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: userProfile, terms and conditions #58

Closed
wants to merge 78 commits into from
Closed

feat: userProfile, terms and conditions #58

wants to merge 78 commits into from

Conversation

paulwer
Copy link
Contributor

@paulwer paulwer commented Sep 26, 2023 •
edited
Loading

closes #49 and #45

introduce:

  • userProfile feature
  • terms while registration
  • select component (required for userProfile fields)
  • textbox component (required for userProfile fields)
  • mark required fields within registration process with "*" (even, when not using userProfile)
  • input-component: make required optional to match default behavior of all components + according changes to existing implementations

lukin and others added 30 commits August 17, 2021 10:30
@lukin
Update dependencies
e8fcdd9
@ifeelcream
Added IDP extension
5dad1e2
@lukin
Prettier
6079295
@lukin
Merge pull request lukin#1
b3c3e3c
@lukin
Update dependencies
69dc820
@lukin
Update configuration files
bf38ae6
@lukin
Build resources
9d13778
@lukin
Update README.md
8db0ead
@lukin
Fix username validation
5a07825
@lukin
Update dependencies
766a38b
@lukin
Update target
3b44fd2
@lukin
Build resources
4e3f17b
@lukin
Rollback target
2622c84
@lukin
Update dependencies
295f5fc
@lukin
Build resources
54e9c33
@ronmrcdo
ui(totp): configure and login otp
4cff8b3 
- added configure and login otp pages
@lukin
Prettier
6067b8f
@lukin
Merge pull request lukin#9
8781594 
[pages] Add Login OTP
@lukin
[link] Remove extra styles
fef457a
@tombrouwer
Update alerts.ftl
a195d30 
Hi,

Thanks for your nice project! I learned a lot of it!

I saw that you don't apply breaks in the switch. This is necessary.

check: https://freemarker.apache.org/docs/ref_directive_switch.html
@tombrouwer
Update locales.ftl
4f79746 
Hi,

An HTML tag issue.
@lukin
[alerts] Use break in switch (lukin#11)
b86e947
@lukin
[locales] Fix HTML tag (lukin#12)
224d737
@lukin
Migrate from Snowpack to Vite
118d107
@YoanSimco
Update register.ftl
52f9892
@lukin
Merge pull request lukin#19
f319a25 
[pages] Fix Register
@lukin
[pages] Add Logout Confirm
2c92c52
@YoanSimco
Update logout-confirm.ftl
5bef95c
@YoanSimco
Apply suggestions to 1 file
ad9e375
@lukin
Merge pull request lukin#21
f5490bd 
[pages] Fix Logout
@paulwer paulwer changed the title feat: adding terms and conditions, while registering feat: userProfile, terms and conditions Sep 30, 2023
@paulwer
Copy link
Contributor Author

paulwer commented Oct 1, 2023

old register view:
Unbenannt

new view:
Unbenannt

i am still testing all field types and will say, when this pr is ready

@paulwer
Copy link
Contributor Author

paulwer commented Oct 2, 2023

@lukin @SimonScholz @CHE1RON anyone likes to support with local testing for this?

@paulwer paulwer marked this pull request as ready for review October 2, 2023 06:09
@CHE1RON
Copy link

CHE1RON commented Oct 2, 2023

For now, I cannot provide the time to do so (properly) 😞 but what you're providing looks great!

@paulwer
Copy link
Contributor Author

paulwer commented Oct 2, 2023 •
edited
Loading

due to overlapping changes from #56 with the input.ftl component and #67 with recaptcha component needed to edit within register-user-profile.ftl this PR requires them to be merged first. Therefore I will mark this as draft again.

Deps:

Please stand by or may assist to close them is you like <3

@paulwer paulwer marked this pull request as draft October 2, 2023 07:57
@paulwer paulwer mentioned this pull request Oct 2, 2023
Closed
2 tasks
@SimonScholz
Copy link

Sorry I did not really had time to look into this further:
Just tried to build the patch-6 branch and deployed it, but the template seems to have issues:

image

@paulwer
Copy link
Contributor Author

paulwer commented Oct 20, 2023 •
edited
Loading

@SimonScholz thank you, for the checkup, this error is related to:

due to overlapping changes from #56 with the input.ftl component and #67 with recaptcha component needed to edit within register-user-profile.ftl this PR requires them to be merged first. Therefore I will mark this as draft again.

Deps:

Please stand by or may assist to close them is you like <3

Sorry for the dirty PR Implementation😒
Both have to be merged first :(

f.ex. your error was issued, due to the eye component(the icon within the password component) does not exists yet.

@ThallesP ThallesP mentioned this pull request Jan 29, 2024
Open
@paulwer
Copy link
Contributor Author

paulwer commented Mar 5, 2024

@lukin keycloak 24 was release and will bring breaking changes, i will include probably next week

@CHE1RON
Copy link

CHE1RON commented Mar 5, 2024

Glad to hear that, thanks so much for your ongoing efforts!

@paulwer
Copy link
Contributor Author

paulwer commented Mar 18, 2024

@CHE1RON as of workload, we are currently not upgrading to v24, so it will take some additional time :(

@paulwer
Copy link
Contributor Author

paulwer commented Jun 19, 2024

closed in favor for:
#96

@paulwer paulwer closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terms and conditions in registry.ftl