Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create LSP14Ownable2Step specs #129

Merged
merged 9 commits into from
Sep 27, 2022
Merged

Create LSP14Ownable2Step specs #129

merged 9 commits into from
Sep 27, 2022

Conversation

b00ste
Copy link
Member

@b00ste b00ste commented Sep 26, 2022

What does this PR introduce?

This PR introduces LSP14Ownable2Step, an LSP focused towards the following processes:

  • owning a contract
  • transferring ownership of a contract
  • renouncing ownership of a contract

Introduced features:

  • Transfer ownership in 2 steps.
  • Renounce ownership in 2 steps.
  • Notify the new owner whenever the first step of transfer ownership is executed.
  • Notify both the old owner and the new owner whenever the process of transferring ownership is complete.

@b00ste b00ste requested review from CJ42, YamenMerhi and frozeman and removed request for CJ42 and YamenMerhi September 26, 2022 12:44
YamenMerhi
YamenMerhi reviewed Sep 26, 2022
View reviewed changes
LSPs/LSP-0-ERC725Account.md Outdated Show resolved Hide resolved
LSPs/LSP-9-Vault.md Outdated Show resolved Hide resolved
LSPs/LSP-14-Ownable2Step.md Outdated Show resolved Hide resolved
LSPs/LSP-9-Vault.md Outdated Show resolved Hide resolved
@frozeman frozeman merged commit e26a723 into main Sep 27, 2022
@frozeman frozeman deleted the create/LSP14Ownable2Step branch September 27, 2022 14:25
@CJ42 CJ42 mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozeman frozeman frozeman approved these changes

@CJ42 CJ42 CJ42 approved these changes

@YamenMerhi YamenMerhi YamenMerhi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b00ste @frozeman @CJ42 @YamenMerhi