Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capturing in the incorrect resolutions #39

Closed
2 of 3 tasks
Tracked by #109
lulzsun opened this issue Sep 27, 2022 · 4 comments
Closed
2 of 3 tasks
Tracked by #109

Capturing in the incorrect resolutions #39

lulzsun opened this issue Sep 27, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@lulzsun
Copy link
Owner

lulzsun commented Sep 27, 2022

There is an issue with capturing games that display a splash screen window at the initial launch of the executable.

The initial approach we take before recording is to immediately retrieve the window handle of the game process that has just launched. If we retrieve the handle quick enough, it may end up being the splash screen window (or some semi-initialized window) and not the actual game window size.

Therefore, the output recording capture will be set at the resolution of the splash screen and not the actual game. This is not intended behavior.

Below are the following conflicted window handle class names that were recorded displaying this issue:

"SplashScreenWindow" - Tekken 7
"CoD Splash Screen" - Call of Duty®: Modern Warfare® II
"SDL_app" - Marauders
"EACLauncherWnd" - Squad

The occurrence is also common with splash screens that use Easy Anti Cheat.

Some proposed solutions:

  • Check the aspect ratio of the initial splash screen to see if it is a standard game resolution
  • Keep a dictionary/regex/string manipulation against conflicted window handle class names (partially implemented)
  • Check periodically if the window resolution has changed
@lulzsun lulzsun added the bug Something isn't working label Sep 27, 2022
sonicv6 added a commit to sonicv6/RePlays that referenced this issue Sep 27, 2022
Wider case match for splash screens lulzsun#39
lulzsun pushed a commit that referenced this issue Sep 27, 2022
Wider case match for splash screens #39
@lulzsun lulzsun changed the title BUG: Capturing in the splash screen resolution Capturing in the splash screen resolution Oct 22, 2022
@lulzsun lulzsun changed the title Capturing in the splash screen resolution Capturing in the incorrect resolutions Apr 10, 2023
@brynjolf
Copy link

brynjolf commented Jul 6, 2023

I run into this all the time to the point I made an AviSynth script just to crop the video to correct resolution. Let me know if you need help to reproduce it.

It is quite annoying though

@lulzsun
Copy link
Owner Author

lulzsun commented Jul 7, 2023

Are you currently on the nightly release? There were some changes to the recording backend (#109) that may have solved your issue. If you are on the nightly release, please provide the log files and mention any games that were giving you trouble, and I will take a look at it.

@brynjolf
Copy link

It seems to be working fine for me in the latest nightly. Not sure exactly which version fixed it for me since I been away during summer. Thank you anyhow :)

@lulzsun
Copy link
Owner Author

lulzsun commented Aug 19, 2023

That's good to hear! Most of the recording issues have been resolved so far thanks to refactoring efforts (#109), and so I feel confident enough to be closing this issue for now. Thanks for reporting back!

@lulzsun lulzsun closed this as completed Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants