[LUM-583] - Handle re-delegate assets from a disabled validator #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebascou
requested changes
Jun 14, 2023
There was a problem hiding this comment.
Implementation looks ok to me but I think we should keep things a bit more simple for now.
See my comments to be discussed (cc @Segfaultd).
lebascou
requested changes
Jun 16, 2023
lebascou
requested changes
Jun 22, 2023
Segfaultd
approved these changes
Jun 22, 2023
…elegateToActiveValidators and helper functions
lebascou
requested changes
Jun 22, 2023
lebascou
approved these changes
Jun 28, 2023
* rc/v1.5: (58 commits) Fix consensus module registration Migrate consensus params and properly register keeper Add format for import ordering Add new NewMsgServerImpl for beam module Add RegisterMsgServer for RegisterServices in x/airdrop/module.go Add RegisterMsgServer for RegisterServices in x/millions/module.go Formatting Fixed ICA callbacks handlers registration Fix usage between port owner name and port ID Fixed ignite gov module config Add comment IBC Stack revamp Redundant implementation Install more dependencies Remove capabilities for ownership transfer Unused ClaimCapability anymore Use store key for consistence Move back proto to their original path for backward compatibility Revert "Fix codecs registration" Fix codecs registration ...
* rc/v1.5: Fix import ordering Update metadata for EditDeposit and ValidateBasic static check Fix linting errors Fix format check Add edit deposit feature
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue / Context
In the current implementation of cosmos millions there is no mechanism in place that allows to re-delegate assets from a misbehaving validator to other validators.
This PR introduces the ability to disable validator(s) by governance proposal and consequently re-delegate their assets to other active validators of the pool.
Implemented solution