Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooltip): restrict open on focus visible #1087

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

gcornut
Copy link
Member

@gcornut gcornut commented Feb 8, 2024

General summary

Restrict opening Tooltip on anchor focus only when focus is visible (keyboard driven).

StoryBook: https://39ab6f3b--5fbfb1d508c0520021560f10.chromatic.com/ (Chromatic build) ⚠️ Outdated commit

Copy link
Contributor

@hchevallier hchevallier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcornut gcornut force-pushed the feat/tooltip-only-on-focus-visible branch from c46bed8 to 78e4499 Compare February 13, 2024 14:13
@gcornut
Copy link
Member Author

gcornut commented Feb 13, 2024

Test OK
Tooltip appears on keyboard focus ✔️
Tooltip does not appear on other kind of focus ✔️

@gcornut gcornut merged commit 730dab1 into master Feb 13, 2024
7 checks passed
@gcornut gcornut deleted the feat/tooltip-only-on-focus-visible branch February 13, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants