Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus EP: fix malformed _total metrics #1411

Closed
wants to merge 1 commit into from
Closed

Prometheus EP: fix malformed _total metrics #1411

wants to merge 1 commit into from

Conversation

fsck-block
Copy link
Contributor

Fix für #1410

Wenn's gefällt, bitte übernehmen.

@fsck-block
Copy link
Contributor Author

fsck-block commented Feb 6, 2024 •
edited
Loading

The "strncpy" family of functions do not properly handle strings that are not null terminated.
Leider hat die statische code analyse etwas gegen das doch einfache Statement. Kann vielleicht nicht so gut mit dem sizeof() umgehen. Aus meiner Sicht ist hier alles in Ordnung.

@lumapu
Copy link
Owner

lumapu commented Feb 6, 2024

ja diese Code-Analyse ist mit vorsicht zu genießen und auch nur vorübergehend drin - die soll nicht davon abhalten hier PRs einzustellen.

lumapu added a commit that referenced this pull request Feb 6, 2024
@lumapu
0.8.75
90d4df4 
* fix active power control value #1406, #1409
* update Mqtt lib to version `1.6.0`
* take care of null terminator of chars #1410, #1411
@lumapu lumapu self-assigned this Feb 6, 2024
@lumapu lumapu added the fixed dev fixed label Feb 6, 2024
lumapu added a commit that referenced this pull request Feb 7, 2024
@lumapu
0.8.76
7c532ca 
* revert changes from yesterday regarding snprintf and its size #1410, #1411
* reduced cppcheck linter warnings significantly
* try to improve ePaper (ghosting) #1107
@fsck-block fsck-block mentioned this pull request Feb 8, 2024
Closed
@lumapu lumapu closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lumapu lumapu

Labels
fixed dev fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsck-block @lumapu