breaking: A FlingRotation instance no longer automatically starts on

construction; the `start()` method should be called manually after instantiation.
lume · Jun 6, 2021 · 8a1b4b7 · 8a1b4b7
1 parent f1a2856
commit 8a1b4b7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/packages/lume/src/cameras/CameraRig.ts b/packages/lume/src/cameras/CameraRig.ts
@@ -61,7 +61,7 @@ export class CameraRig extends Node {
 			rotationYTarget: this,
 			minFlingRotationX: this.minPolarAngle,
 			maxFlingRotationX: this.maxPolarAngle,
-		})
+		}).start()
 
 		this.scrollFling = new ScrollFling({
 			target: this.scene,

diff --git a/packages/lume/src/interaction/FlingRotation.ts b/packages/lume/src/interaction/FlingRotation.ts
@@ -63,8 +63,6 @@ export class FlingRotation {
 		// specified by the input options), at least for now.
 		if (!this.rotationXTarget) this.rotationXTarget = this.rotationYTarget.children[0] as Node
 		if (!this.interactionInitiator) this.interactionInitiator = this.rotationXTarget
-
-		this.start()
 	}
 
 	#onMove?: (event: PointerEvent) => void