Skip to content

Commit

Permalink
Merge pull request #302 from lume/add-missing-prop-type
Browse files Browse the repository at this point in the history
add missing active prop for cameras in JSX
  • Loading branch information
trusktr committed May 14, 2024
2 parents ea8a0e5 + 841d23b commit d6bf8fc
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
.DS_Store
node_modules/
package-lock.json
.vscode/
*.log

Expand Down
2 changes: 1 addition & 1 deletion dist/cameras/Camera.d.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Camera as ThreeCamera } from 'three/src/cameras/Camera.js';
import { Element3D, type Element3DAttributes } from '../core/Element3D.js';
export type CameraAttributes = Element3DAttributes | 'aspect' | 'near' | 'far' | 'zoom';
export type CameraAttributes = Element3DAttributes | 'aspect' | 'near' | 'far' | 'active' | 'zoom';
/**
* @class Camera
*
Expand Down
2 changes: 1 addition & 1 deletion dist/cameras/Camera.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/cameras/Camera.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {booleanAttribute, element, numberAttribute} from '@lume/element'
import {Camera as ThreeCamera} from 'three/src/cameras/Camera.js'
import {Element3D, type Element3DAttributes} from '../core/Element3D.js'

export type CameraAttributes = Element3DAttributes | 'aspect' | 'near' | 'far' | 'zoom'
export type CameraAttributes = Element3DAttributes | 'aspect' | 'near' | 'far' | 'active' | 'zoom'
// | 'lookAt' // TODO

/**
Expand Down

0 comments on commit d6bf8fc

Please sign in to comment.