Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Breadcrumb CSS nesting #21

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Fix Breadcrumb CSS nesting #21

merged 1 commit into from
Apr 29, 2019

Conversation

megamaddu
Copy link
Member

My last Breadcrumb fix didn't completely resolve the issue

@megamaddu megamaddu self-assigned this Apr 29, 2019
@megamaddu
Copy link
Member Author

I tested this locally in flapjack and powerpuff

arthurxavierx
arthurxavierx approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@arthurxavierx arthurxavierx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@megamaddu megamaddu merged commit 225bfdd into master Apr 29, 2019
@megamaddu megamaddu deleted the madeline/fix-breadcrumb-again branch April 29, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurxavierx arthurxavierx arthurxavierx approved these changes

@kimispencer kimispencer Awaiting requested review from kimispencer

Assignees

@megamaddu megamaddu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@megamaddu @arthurxavierx