-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous integration #24
Comments
@ericpre If you are happy with this CI implementation, please cloase this issue. Otherwise we can work on it further. |
I have wrote a couple of comments on #30. Having Azure pipeline would be worth to test on the 3 main platforms. |
Working on adding Azure pipeline in #33 . |
Now both Travis and Azure pipelines work well. I also don't seem to understand why in here if I set as |
Yes, both are working, but I would suggest to do the following:
At the moment, it azure is doing almost the same as travis, using packages from pypi instead of conda packages. This is because you are missing the files defining what package to install in the conda environment (see https://github.com/hyperspy/ci-scripts#conda-environment). Since pip and conda are the main way to install python packages, this is useful to check that both are working fine. For a pure python library, this may sounds overkill but it has the advantage that it checked that the dependencies are working fine in both cases. Also packages are usually release first on pypi before being available on anaconda cloud and if the update of a dependency break the test suite, it should come up first on travis. As mentioned in hyperspy/ci-scripts#1, I will follow up with a PR to clarify these points.
Can you please point out to a specific build? |
@ericpre Here are the examples:
The same issue happens when I merge my personal fork to the lumispy repository. |
It would be good to set up continuous integration for this repository.
It is well documented online but as a starting point it may be worth having a look:
https://github.com/hyperspy/ci-scripts
The text was updated successfully, but these errors were encountered: